cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8917) Add api/way to get plugins results even when Cordova activity restarts
Date Wed, 11 Nov 2015 18:37:11 GMT

    [ https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000864#comment-15000864
] 

ASF GitHub Bot commented on CB-8917:
------------------------------------

Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/239#discussion_r44567817
  
    --- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
    @@ -0,0 +1,71 @@
    +/*
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +*/
    +package org.apache.cordova;
    +
    +
    +import org.json.JSONException;
    +import org.json.JSONObject;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +public class ResumeCallback extends CallbackContext {
    +    private final String TAG = "CordovaResumeCallback";
    +    private String serviceName;
    +    private PluginManager pluginManager;
    +
    +    public ResumeCallback(String serviceName, PluginManager pluginManager) {
    +        super("resumecallback", null);
    +        this.serviceName = serviceName;
    +        this.pluginManager = pluginManager;
    +    }
    +
    +    @Override
    +    public void sendPluginResult(PluginResult pluginResult) {
    +        synchronized (this) {
    +            if (finished) {
    +                return;
    --- End diff --
    
    Yup, that sounds reasonable


> Add api/way to get plugins results even when Cordova activity restarts  
> ------------------------------------------------------------------------
>
>                 Key: CB-8917
>                 URL: https://issues.apache.org/jira/browse/CB-8917
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity will be
killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead and the
webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same with even more
platforms)
> possible solution for this is to add metadata to the device ready event with incoming
data from plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message