cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (CB-7020) Contacts find function signature making mobilespec fail
Date Thu, 19 Nov 2015 13:09:11 GMT

     [ https://issues.apache.org/jira/browse/CB-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vladimir Kotikov closed CB-7020.
--------------------------------
    Resolution: Fixed

This was fixed in [432b014|https://github.com/apache/cordova-plugin-contacts/commit/432b0143442a689e349e347f33ee85aeb2d28663],
closing.

> Contacts find function signature making mobilespec fail
> -------------------------------------------------------
>
>                 Key: CB-7020
>                 URL: https://issues.apache.org/jira/browse/CB-7020
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>    Affects Versions: Master
>            Reporter: Carlos Santana
>
> Back in April [1] when navigator.contacts.pickContact() was added the signature for navigator.contacts.find()
was changed
> From:
> navigator.contacts.find:function(fields, successCB, errorCB, options) {
> To:
> navigator.contacts.find:function(successCB, errorCB, fields, options) {
> I think this is a braking change and the reason why mobilespec is failing.
> If there are no objections I think the find method should be put back as it was before
publishing a new version with a different api signature. I created an issue [2] to track
> Or if the consensus is for find function to have a new signature, then the version of
the plugin needs to be increase to reflect the api break, and maybe a note in the doc.
> [1]: https://github.com/apache/cordova-plugin-contacts/commit/d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b#diff-6a72b46d7f0c34e1070ce85b959f30fcR46



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message