cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6928) Wrong behaviour transferring cacheable content
Date Mon, 09 Nov 2015 13:35:11 GMT

    [ https://issues.apache.org/jira/browse/CB-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996529#comment-14996529
] 

ASF GitHub Bot commented on CB-6928:
------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/112

    CB-6928 Wrong behaviour transferring cacheable content

    Adds support of 304 handling for iOS, Windows and adds a corresponding test.
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-6928) 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer CB-6928

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----
commit e8fa2c3a67144133e060f97e6dd5964cef0116de
Author: daserge <v-seshak@microsoft.com>
Date:   2015-11-09T13:25:03Z

    CB-6928 Wrong behaviour transferring cacheable content
    
    Adds support of 304 handling for iOS, Windows and adds a corresponding test

----


> Wrong behaviour transferring cacheable content
> ----------------------------------------------
>
>                 Key: CB-6928
>                 URL: https://issues.apache.org/jira/browse/CB-6928
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: 3.5.0
>            Reporter: Javier Puerto
>            Priority: Minor
>         Attachments: CB-6928.diff
>
>
> Use case:
> Transfer resources from server to the device. To avoid unnecessary use of the device
bandwidth, the resources that exists already are checked with the "If-Modified-Since" header
so server can return 304 status code and update just in case that is needed.
> Result for Android test:
> The plugin doesn't care about the status code, if the request is success, open the InputStream
and copy the content to the file. The problem is that a HTTP status of 304 has no response
and that leads to a corrupted file transfer.
> Fix:
> If status code is 304, doesn't makes sense to process the InputStream. Read the status
code after connection and if it's 304, skip the copy process and return the file entity like
a success transfer.
> I've tested for Android only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message