cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-5479) Save original image to photoalbum when the image is taken from the Camera
Date Wed, 11 Nov 2015 23:15:10 GMT

    [ https://issues.apache.org/jira/browse/CB-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001313#comment-15001313
] 

ASF GitHub Bot commented on CB-5479:
------------------------------------

GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/137

    CB-5479 android: changed saveToPhotoAlbum to save uncompressed images

    It was apparently decided a while back (CB-5749) that we should be saving the uncompressed
image with `saveToPhotoAlbum` rather than the modified image when the camera options `quality`,
`targetHeight`, `targetWidth`, etc. are given. iOS supports this behavior, but Android does
not. This pull request changes the Android code so that when `saveToPhotoAlbum` is specified,
the uncompressed image is saved to the album and the modified image is saved to the application's
cache (and that URI is what is returned to the application). This also makes it so that DATA_URL
actually saves images to the gallery when the flag is enabled (this was previously not the
case). This might be a breaking change for some applications that relied on the old behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-5479

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 19072169f880fcb1806b3d91c3987b7d43c8dd52
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2015-11-11T21:40:33Z

    CB-5479 android: changed saveToPhotoAlbum to save uncompressed images

----


> Save original image to photoalbum when the image is taken from the Camera
> -------------------------------------------------------------------------
>
>                 Key: CB-5479
>                 URL: https://issues.apache.org/jira/browse/CB-5479
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>    Affects Versions: 3.1.0
>            Reporter: Stephan Wezel
>            Assignee: Richard B Knoll
>            Priority: Minor
>              Labels: Android, iOS, triaged
>         Attachments: camera_plugin_save_original_image_to_photoalbum.patch
>
>
> Currently when the option saveToPhotoAlbum is active the modified image (scaled, reduced
image) is saved to the PhotoAlbum.
> At least when the image is taken from the Camera then the original image should be saved
instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message