cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-4921) ContactField Full Example only returns 1 contact
Date Mon, 30 Nov 2015 08:50:11 GMT

    [ https://issues.apache.org/jira/browse/CB-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031500#comment-15031500
] 

ASF GitHub Bot commented on CB-4921:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/92

    CB-4921 Corrects examples by adding missing `multiple` option where multiple contacts
are expected

    A small docs improvement, mentioned in [CB-4921](https://issues.apache.org/jira/browse/CB-4921)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-4291

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit d3b470256514c5c01fa69a037a764db846a63e42
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-11-26T14:42:46Z

    CB-4921 Corrects examples by adding missing `multiple` option where multiple contacts
are expected

----


> ContactField Full Example only returns 1 contact
> ------------------------------------------------
>
>                 Key: CB-4921
>                 URL: https://issues.apache.org/jira/browse/CB-4921
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>    Affects Versions: 2.9.0
>            Reporter: Peter
>            Assignee: Mike Billau
>            Priority: Trivial
>              Labels: reproduced, triaged
>
> There is something unusual about the documented Full Example for ContactField [1] 
> The code example saves a bunch of phone number contacts and then does a *contacts.find*
presumably to demonstrate that the phone numbers just saved can be retrieved OK. 
> The problem with the example is that the *options* does not specify _multiple=true_ and
since the default is _options.multiple=false_ [2] there will never be multiple contacts returned.
So the example won't display all what just got saved, and it is also contrary to the way the
onSuccess method is expecting to iterate over multiple contacts.
> I think the code should say 
> {quote}
> options.multiple=true;
> {quote}
> [1] http://cordova.apache.org/docs/en/3.0.0/cordova_contacts_contacts.md.html#ContactField
> [2] http://cordova.apache.org/docs/en/3.0.0/cordova_contacts_contacts.md.html#contactFindOptions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message