cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3950) Custom labels are removed when a contact is saved on iOS.
Date Thu, 26 Nov 2015 14:58:11 GMT

    [ https://issues.apache.org/jira/browse/CB-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028938#comment-15028938
] 

ASF GitHub Bot commented on CB-3950:
------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/90#discussion_r45985736
  
    --- Diff: src/ios/CDVContact.m ---
    @@ -750,7 +750,9 @@ + (CFStringRef)convertContactTypeToPropertyLabel:(NSString*)label
         } else if ([label caseInsensitiveCompare:kW3ContactUrlProfile] == NSOrderedSame)
{
             type = kABPersonHomePageLabel;
         } else {
    -        type = kABOtherLabel;
    +        // CB-3950 If label is not one of kW3*Label constants, threat it as custom label.
    +        // Otherwise fetching contact and then saving it will mailform this label in
address book.
    --- End diff --
    
    Typo: mailform -> malform


> Custom labels are removed when a contact is saved on iOS.
> ---------------------------------------------------------
>
>                 Key: CB-3950
>                 URL: https://issues.apache.org/jira/browse/CB-3950
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>         Environment: iOS
> Cordova 2.7.0
>            Reporter: Olivier Louvignes
>            Assignee: Vladimir Kotikov
>              Labels: contacts, ios, reproduced, triaged
>
> When I update an existing contact that has some custom labels (like "BlackBerry", "iPhone"),
theses labels are replaced by "other" even if I do not touch the "phoneNumbers" array.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message