Return-Path: 
 <issues-return-50217-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A11FF1049F
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Tue, 20 Oct 2015 09:10:24 +0000 (UTC)
Received: (qmail 64377 invoked by uid 500); 20 Oct 2015 08:55:53 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 64350 invoked by uid 500); 20 Oct 2015 08:55:53 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 64328 invoked by uid 99); 20 Oct 2015 08:55:53 -0000
Received: from Unknown (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 08:55:53 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id C36242C1F5E
	for <issues@cordova.apache.org>; Tue, 20 Oct 2015 08:55:27 +0000 (UTC)
Date: Tue, 20 Oct 2015 08:55:27 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12905508.1444998980000.6087.1445331327798@Atlassian.JIRA>
In-Reply-To: <JIRA.12905508.1444998980000@Atlassian.JIRA>
References: <JIRA.12905508.1444998980000@Atlassian.JIRA>
 <JIRA.12905508.1444998980693@arcas>
Subject: [jira] [Commented] (CB-9815) Engine name="cordova" should check
 tools version, not platforms
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964812#comment-14964812 ] 

ASF subversion and git services commented on CB-9815:
-----------------------------------------------------

Commit acff7231934374f251333388f82467950fd577f4 in cordova-lib's branch refs/heads/master from sgrebnov
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=acff723 ]

CB-9815 Engine name="cordova" should check tools version, not platforms. This closes #324


> Engine name="cordova" should check tools version, not platforms
> ---------------------------------------------------------------
>
>                 Key: CB-9815
>                 URL: https://issues.apache.org/jira/browse/CB-9815
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-lib, engines, versioning
>
> If I use the following engine tag inside some of my plugins 
> {code}
> <engine name="cordova" version=">=4.3.0" />
> {code}
> I see that the tools compares version w/ platforms versions when installing plugins, not the tools version.
> This is due to the following implementation. We should update implementation similar to cordova-plugman and threat cordova version as tools version not platforms. 
> https://github.com/apache/cordova-lib/blob/d12be7c3e7b532bdea43321db2a3ce76b5f4d39f/cordova-lib/src/plugman/util/default-engines.js#L22
> {code}
> module.exports = function(project_dir){
>     return {
>         'cordova':
>             { 'platform':'*', 'scriptSrc': path.join(project_dir,'cordova','version') },
>         'cordova-plugman':
>             { 'platform':'*', 'currentVersion': require('../../../package.json').version },
>         'cordova-android':
>             { 'platform':'android', 'scriptSrc': path.join(project_dir,'cordova','version') },
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org