Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9AB131720C for ; Fri, 16 Oct 2015 12:37:05 +0000 (UTC) Received: (qmail 49036 invoked by uid 500); 16 Oct 2015 12:37:05 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 49003 invoked by uid 500); 16 Oct 2015 12:37:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 48982 invoked by uid 99); 16 Oct 2015 12:37:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2015 12:37:05 +0000 Date: Fri, 16 Oct 2015 12:37:05 +0000 (UTC) From: "Sergey Grebnov (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CB-9815) Engine name="cordova" should test tools version, not platform MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Sergey Grebnov created CB-9815: ---------------------------------- Summary: Engine name="cordova" should test tools version, not platform Key: CB-9815 URL: https://issues.apache.org/jira/browse/CB-9815 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Reporter: Sergey Grebnov Assignee: Sergey Grebnov If I use the following engine tag inside some of my plugins {code} {code} I see that the tools compares version w/ platforms versions when installing plugins, not the tools version. This is due to the following implementation. We should update implementation similar to cordova-plugman and threat cordova version as tools version not platforms. https://github.com/apache/cordova-lib/blob/d12be7c3e7b532bdea43321db2a3ce76b5f4d39f/cordova-lib/src/plugman/util/default-engines.js#L22 {code} module.exports = function(project_dir){ return { 'cordova': { 'platform':'*', 'scriptSrc': path.join(project_dir,'cordova','version') }, 'cordova-plugman': { 'platform':'*', 'currentVersion': require('../../../package.json').version }, 'cordova-android': { 'platform':'android', 'scriptSrc': path.join(project_dir,'cordova','version') }, {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org