Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 3 Oct 2015 01:41:26 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12902101.1443787855000.15837.1443836486696@Atlassian.JIRA>
In-Reply-To: <JIRA.12902101.1443787855000@Atlassian.JIRA>
References: <JIRA.12902101.1443787855000@Atlassian.JIRA>
 <JIRA.12902101.1443787855972@arcas>
Subject: [jira] [Commented] (CB-9739) Prevent coho from creating broken
 packages including CRLF on Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942038#comment-14942038 ] 

ASF GitHub Bot commented on CB-9739:
------------------------------------

Github user csantanapr commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/95#discussion_r41082335
  
    --- Diff: src/create-verify-archive.js ---
    @@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
         var absOutDir = path.resolve(outDir);
     
         yield repoutil.forEachRepo(repos, function*(repo) {
    +        if(isWin) {
    --- End diff --
    
    @nikhilkh I'm Ok with the change I was just curious of why the isWin, that's all.
    I was not trying to blocked the merge. Merge away..
    +1


> Prevent coho from creating broken packages including CRLF on Windows
> --------------------------------------------------------------------
>
>                 Key: CB-9739
>                 URL: https://issues.apache.org/jira/browse/CB-9739
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Coho
>         Environment: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> {code}git config --get core.autocrlf{code} is *true* by default on Windows, which causes line endings to be converted to CRLF on clone so that further create-archive embeds CRLFs into all files including shell scripts -> this causes failures on Unix systems.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org