Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 28 Oct 2015 18:22:28 +0000 (UTC)
From: "Perry Stoll (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12896216.1443125412000.87259.1446056548041@Atlassian.JIRA>
In-Reply-To: <JIRA.12896216.1443125412000@Atlassian.JIRA>
References: <JIRA.12896216.1443125412000@Atlassian.JIRA>
 <JIRA.12896216.1443125412534@arcas>
Subject: [jira] [Commented] (CB-9702) Fix plugin initialization based on
 XCode 7.0 compiler warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978954#comment-14978954 ] 

Perry Stoll commented on CB-9702:
---------------------------------

Jose,

I suspect this change has not been released yet. It is not fatal, it is just a warning. And the stated behavior (those condition evaluations being true) is safe in this case. 

But this cleanup was a reminder - never ignore compiler warnings!

Perry


> Fix plugin initialization based on XCode 7.0 compiler warnings
> --------------------------------------------------------------
>
>                 Key: CB-9702
>                 URL: https://issues.apache.org/jira/browse/CB-9702
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Network Information
>    Affects Versions: Master
>         Environment: XCode Version 7.0 (7A220)
>            Reporter: Perry Stoll
>
> xcode complains "These will always evaluate to true", which, looking at these lines, makes sense. These things are objects, taking their address will always yield a non-null value. 
> {code}
> cordova-plugin-network-information pstoll$ git diff
> diff --git a/src/ios/CDVConnection.m b/src/ios/CDVConnection.m
> index 3749767..223dd7c 100644
> --- a/src/ios/CDVConnection.m
> +++ b/src/ios/CDVConnection.m
> @@ -118,7 +118,7 @@
>      [self.internetReach startNotifier];
>      [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(updateConnectionType:)
>                                                   name:kReachabilityChangedNotification object:nil];
> -    if (&UIApplicationDidEnterBackgroundNotification && &UIApplicationWillEnterForegroundNotification) {
> +    if (UIApplicationDidEnterBackgroundNotification && UIApplicationWillEnterForegroundNotification) {
>          [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onPause) name:UIApplicationDidEnterBackgroundNotification object:nil];
>          [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(onResume) name:UIApplicationWillEnterForegroundNotification object:nil];
>      }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org