Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Oct 2015 09:25:27 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12838332.1434496542000.38019.1445592327779@Atlassian.JIRA>
In-Reply-To: <JIRA.12838332.1434496542000@Atlassian.JIRA>
References: <JIRA.12838332.1434496542000@Atlassian.JIRA>
 <JIRA.12838332.1434496542456@arcas>
Subject: [jira] [Commented] (CB-9193) [Camera] Add option to choose from
 library even if source is camera
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970708#comment-14970708 ] 

ASF GitHub Bot commented on CB-9193:
------------------------------------

Github user dpolivy commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-150526428
  
    @purplecabbage On Android, the strings were previously [hardcoded](https://github.com/apache/cordova-plugin-camera/pull/104/files#diff-f2e83abdaf34884df7e74b6493cf2dd7L79) into the plugin. My commit actually [moved them out into plugin.xml](https://github.com/apache/cordova-plugin-camera/pull/104/files#diff-53f390d375398624afe1cfe1125f42bfR79) so they could actually be localized. The other strings (e.g. the intent names) are actually provided by the OS based on the available activities. For WP, it is all built in to the OS, and for iOS the one new string (Library) is added in a localizable manner consistent with other strings in plugins.
    
    I don't necessarily disagree with your approach to splitting this into multiple plugins, however I really do believe there is a useful scenario where the camera UI launches first, but the user has a quick escape into the library. That wouldn't be supported by splitting into 3 plugins. Instead if you really want more of a consistent experience you just have to write to the native camera APIs directly on each platform and built a custom "Cordova" standard UI on top of them. Having a modal source chooser step just adds complexity to the user experience in most cases. Far better from a UX perspective to default to the 90% case (as determined by the developer for their app) but allow easy toggling between the various options.
    
    In any case, it seems that there's no future hope for this PR in its current form. I still do advocate that the problem I'm trying to solve is a valuable and important addition to the Cordova plugins, but I'm certainly open to the form it takes as long as it meets the user experience bar we're trying to achieve.


> [Camera] Add option to choose from library even if source is camera
> -------------------------------------------------------------------
>
>                 Key: CB-9193
>                 URL: https://issues.apache.org/jira/browse/CB-9193
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>            Reporter: Dan Polivy
>
> There are many scenarios where an app might allow a user to take a picture via the camera, OR choose a photo from their library. With the current camera plugin implementation, the developer must first present some type of chooser UI to allow the user to initiate either the camera, or the library.
> A potentially more efficient approach is to launch the camera by default, and within the camera UI provide an option to switch over to the library -- similar to the way the default Camera app works in iOS.
> I am working on a PR to add this functionality via a new CameraOptions setting.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org