cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9909) Android requirements provides invalid android path on Windows
Date Thu, 29 Oct 2015 23:49:28 GMT

    [ https://issues.apache.org/jira/browse/CB-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981587#comment-14981587
] 

ASF GitHub Bot commented on CB-9909:
------------------------------------

GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-android/pull/237

    CB-9909 Shouldn't escape spaces in paths on Windows.

    Instead on windows just wrap in quotes. Note that this value is only never executed directly
- just displayed to the user. But this way they can copy and paste successfully on Windows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-android fix-android-cmd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit e6d835df2292be642de16eb64990dc0558f00c97
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-10-29T22:30:48Z

    CB-9909 Shouldn't escape spaces in paths on Windows.

----


> Android requirements provides invalid android path on Windows
> -------------------------------------------------------------
>
>                 Key: CB-9909
>                 URL: https://issues.apache.org/jira/browse/CB-9909
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>
> When you do {{cordova requirements}} for the android platform and "Android target" is
not installed, on Windows it suggests opening the SDK by running:
> {{C:\Program\ Files\ (x86)\Android\android-sdk\tools\android.bat}}
> Escaping spaces like this doesn't work on Windows. Instead, for Windows, we should just
wrap it in quotes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message