cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9821) Fix EventEmitter incorrect trace level usages
Date Mon, 19 Oct 2015 09:57:05 GMT

    [ https://issues.apache.org/jira/browse/CB-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963089#comment-14963089
] 

ASF GitHub Bot commented on CB-9821:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/325#issuecomment-149171021
  
    ping @vladimir-kotikov  - could you please review this simple change


> Fix EventEmitter incorrect trace level usages
> ---------------------------------------------
>
>                 Key: CB-9821
>                 URL: https://issues.apache.org/jira/browse/CB-9821
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-lib
>
> I see some places where we use incorrect log level argument, like 'err' or 'debug' so
those traces are ignored and not displayed or could be intercepted by CordovaCLI/Plugman or
other tools. 
> For example (we don't support 'debug'; the correct argument here is 'verbose'):
> {code}
> function getPluginsHookScripts(hook, opts) {
>     // args check
>     if (!hook) {
>         throw new Error('hook type is not specified');
>     }
>     // In case before_plugin_install, after_plugin_install, before_plugin_uninstall hooks
we receive opts.plugin and
>     // retrieve scripts exclusive for this plugin.
>     if(opts.plugin) {
>         events.emit('debug', 'Executing "' + hook + '"  hook for "' + opts.plugin.id
+ '" on ' + opts.plugin.platform + '.');
>         // if plugin hook is not run for specific platform then use all available platforms
>         return getPluginScriptFiles(opts.plugin, hook, opts.plugin.platform  ? [opts.plugin.platform]
: opts.cordova.platforms);
>     }
>     events.emit('debug', 'Executing "' + hook + '"  hook for all plugins.');
>     return getAllPluginsHookScriptFiles(hook, opts);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message