cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9815) Engine name="cordova" should check tools version, not platforms
Date Sat, 17 Oct 2015 15:34:05 GMT

    [ https://issues.apache.org/jira/browse/CB-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961941#comment-14961941
] 

ASF GitHub Bot commented on CB-9815:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/324#issuecomment-148925139
  
    @TimBarham I see your point, but all places where I saw that engine name usage all devs
thought they check cordova version - see examples below. Taking into account that we will
apply this change only in next/future cordova version where we have pinned platforms versions
lower than cordova version itself  non of existing plugins will be broken.
    
    Also, I see that this is not covere in docs at all so we may want to contribute some info
to Plugin Dev Guide 
    
    InAppBrowser plugin
    ```
        <engines>
          <engine name="cordova" version=">=3.1.0" /><!-- Needs cordova/urlutil
-->
        </engines>
    ```
    phonegap-facebook-plugin
    ```
        <engines>
            <!-- Requires > 3.3.* because of the custom Framework tag for iOS [CB-5238]
-->
            <!-- Requires > 3.5.0 because of the custom Framework tag for Android [CB-6698]
-->
            <engine name="cordova" version=">=3.5.0" />
        </engines>
    ```


> Engine name="cordova" should check tools version, not platforms
> ---------------------------------------------------------------
>
>                 Key: CB-9815
>                 URL: https://issues.apache.org/jira/browse/CB-9815
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-lib, engines, versioning
>
> If I use the following engine tag inside some of my plugins 
> {code}
> <engine name="cordova" version=">=4.3.0" />
> {code}
> I see that the tools compares version w/ platforms versions when installing plugins,
not the tools version.
> This is due to the following implementation. We should update implementation similar
to cordova-plugman and threat cordova version as tools version not platforms. 
> https://github.com/apache/cordova-lib/blob/d12be7c3e7b532bdea43321db2a3ce76b5f4d39f/cordova-lib/src/plugman/util/default-engines.js#L22
> {code}
> module.exports = function(project_dir){
>     return {
>         'cordova':
>             { 'platform':'*', 'scriptSrc': path.join(project_dir,'cordova','version')
},
>         'cordova-plugman':
>             { 'platform':'*', 'currentVersion': require('../../../package.json').version
},
>         'cordova-android':
>             { 'platform':'android', 'scriptSrc': path.join(project_dir,'cordova','version')
},
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message