cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9747) Android parser fails if the activity class has been redefined (using android:name)
Date Mon, 05 Oct 2015 21:29:26 GMT

    [ https://issues.apache.org/jira/browse/CB-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944084#comment-14944084
] 

ASF GitHub Bot commented on CB-9747:
------------------------------------

GitHub user ogoguel opened a pull request:

    https://github.com/apache/cordova-lib/pull/315

    CB-9747 Fix Android Parser

    Fix parser error if the activity name refers a full package class, instead of just the
class
    Added tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ogoguel/cordova-lib CB-9747-tentative

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #315
    
----
commit 5ca3588c4fb8fa35915bdb644a2ba71454bd20f3
Author: Olivier Goguel <o@goguel.com>
Date:   2015-10-05T19:45:49Z

    CB-9747

commit 7c6d2f41a9f9f9c21866623073c146e84c6f520a
Author: Olivier Goguel <o@goguel.com>
Date:   2015-10-05T21:25:53Z

    CB-9747 added tests

----


> Android parser fails if the activity class has been redefined (using android:name)
> ----------------------------------------------------------------------------------
>
>                 Key: CB-9747
>                 URL: https://issues.apache.org/jira/browse/CB-9747
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.3.2
>         Environment: Android
>            Reporter: Olivier Goguel
>
> If the name of the class that implements the activity has been modified to include a
full package name, the android parser fails as it still expects to find the Activity class
under the package name defined in the manifest
> Ex:
> <manifest package="com.myapp" ...>
> <activity android:name="MainActivity"> ====> OK, as the parser is searching
the java file under com/myapp
> However:
> <activity android:name="net.del7a.MyActivity"> ====> KO, as the parser is still
searching the java file under com/myapp instead of net/del7a
> Error: ENOENT, no such file or directory '/Users/olivier/Code/POM/cordova/platforms/android/src/com/myapp'
>     at Object.fs.readdirSync (fs.js:654:18)
>     at android_parser.update_from_config (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/metadata/android_parser.js:266:25)
>     at android_parser.update_project (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/metadata/android_parser.js:335:14)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message