cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9741) Use Proper Android Internal Storage API in AudioPlayer
Date Fri, 02 Oct 2015 22:04:26 GMT

    [ https://issues.apache.org/jira/browse/CB-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941848#comment-14941848
] 

ASF GitHub Bot commented on CB-9741:
------------------------------------

GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/72

    CB-9741 Updated Android AudioPlayer to use Internal Storage api

    The Android Linter points out that /data/data/ should not be hardcoded. This replaces
those hardcoded strings by getting the path from the Activity Context.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-media android-internal-storage-api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit fce19979cff13b5677529d18e2792e282ca9fc9a
Author: riknoll <riknoll@microsoft.com>
Date:   2015-10-02T00:35:57Z

    CB-9741 Updated Android AudioPlayer to use Internal Storage api

----


> Use Proper Android Internal Storage API in AudioPlayer
> ------------------------------------------------------
>
>                 Key: CB-9741
>                 URL: https://issues.apache.org/jira/browse/CB-9741
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Media
>         Environment: Android
>            Reporter: Richard B Knoll
>
> In AudioPlayer.java there are a few locations where "/data/data/" is hardcoded as part
of the path. That internal storage directory can change on multi-user devices so it should
really be accessed using Context.getFilesDir()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message