cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9739) Prevent coho from creating broken packages including CRLF on Windows
Date Fri, 02 Oct 2015 12:17:27 GMT

    [ https://issues.apache.org/jira/browse/CB-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941065#comment-14941065
] 

ASF GitHub Bot commented on CB-9739:
------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-coho/pull/95

    CB-9739 Prevent coho from creating broken packages including CRLF on …

    Windows
    
    We may also need to add `.gitattributes` with
    ```
    * text eol=lf
    ```
    to force LF line endings in the repos.
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-9739)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-coho CB-9739

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-coho/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 0917d59e396d3a1958bcefd20379febeb51b1a6b
Author: daserge <v-seshak@microsoft.com>
Date:   2015-10-02T12:09:56Z

    CB-9739 Prevent coho from creating broken packages including CRLF on Windows

----


> Prevent coho from creating broken packages including CRLF on Windows
> --------------------------------------------------------------------
>
>                 Key: CB-9739
>                 URL: https://issues.apache.org/jira/browse/CB-9739
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Coho
>         Environment: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> {code}git config --get core.autocrlf{code} is *true* by default on Windows, which causes
line endings to be converted to CRLF on clone so that further create-archive embeds CRLFs
into all files including shell scripts -> this causes failures on Unix systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message