cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9739) Prevent coho from creating broken packages including CRLF on Windows
Date Fri, 02 Oct 2015 13:27:26 GMT

    [ https://issues.apache.org/jira/browse/CB-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941126#comment-14941126
] 

ASF GitHub Bot commented on CB-9739:
------------------------------------

Github user csantanapr commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/95#discussion_r41020487
  
    --- Diff: src/create-verify-archive.js ---
    @@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
         var absOutDir = path.resolve(outDir);
     
         yield repoutil.forEachRepo(repos, function*(repo) {
    +        if(isWin) {
    --- End diff --
    
    Why the windows check?
    Can a mac or linux users have a bad git config? and then the check will not run for them.


> Prevent coho from creating broken packages including CRLF on Windows
> --------------------------------------------------------------------
>
>                 Key: CB-9739
>                 URL: https://issues.apache.org/jira/browse/CB-9739
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Coho
>         Environment: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> {code}git config --get core.autocrlf{code} is *true* by default on Windows, which causes
line endings to be converted to CRLF on clone so that further create-archive embeds CRLFs
into all files including shell scripts -> this causes failures on Unix systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message