cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Diego Geffner (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-9733) Empty cordova project shouldn't have DISABLE_PUSH_NOTIFICATIONS enabled by default
Date Thu, 01 Oct 2015 21:13:26 GMT

     [ https://issues.apache.org/jira/browse/CB-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Diego Geffner updated CB-9733:
------------------------------
    Description: 
I was trying to validate and publish an empty Cordova application in the Apple AppStore and
I got this email from apple:

Dear developer,
We have discovered one or more issues with your recent delivery for "<My App Name>".
Your delivery was successful, but you may wish to correct the following issues in your next
delivery: 
Missing Push Notification Entitlement - Your app appears to include API used to register with
the Apple Push Notification service, but the app signature's entitlements do not include the
"aps-environment" entitlement
etc...

The error is because DISABLE_PUSH_NOTIFICATIONS  is disabled by default, so an empty cordova
project has some code referencing push notifications, even if it's not being used. We should
fix that so the developers have a good UX while publishing apps.

One way we could do this, would be to enable DISABLE_PUSH_NOTIFICATIONS  by default, and then
add a hook to the  cordova plugins that add push notifications, so they'll go and disable
that preprocessor flag.

Given that the spirit of the platforms/ folders is to be read-only, we should support in Cordova
an easy way of doing this change, and it shouldn't require modifying the iOS project directly

  was:
I was trying to validate and publish an empty Cordova application in the Apple AppStore and
I got this email from apple:

Dear developer,
We have discovered one or more issues with your recent delivery for "<My App Name>".
Your delivery was successful, but you may wish to correct the following issues in your next
delivery: 
Missing Push Notification Entitlement - Your app appears to include API used to register with
the Apple Push Notification service, but the app signature's entitlements do not include the
"aps-environment" entitlement
etc...

The error is because DISABLE_PUSH_NOTIFICATIONS  is disabled by default, so an empty cordova
project has some code referencing push notifications, even if it's not being used. We should
fix that so the developers have a good UX while publishing apps.

One way we could do this, would be to enable DISABLE_PUSH_NOTIFICATIONS  by default, and then
add a hook to the  cordova plugins that add push notifications, so they'll go and disable
that preprocessor flag.


> Empty cordova project shouldn't have DISABLE_PUSH_NOTIFICATIONS enabled by default
> ----------------------------------------------------------------------------------
>
>                 Key: CB-9733
>                 URL: https://issues.apache.org/jira/browse/CB-9733
>             Project: Apache Cordova
>          Issue Type: Bug
>    Affects Versions: 5.3.2
>         Environment: Mac OS
>            Reporter: Diego Geffner
>            Priority: Minor
>
> I was trying to validate and publish an empty Cordova application in the Apple AppStore
and I got this email from apple:
> Dear developer,
> We have discovered one or more issues with your recent delivery for "<My App Name>".
Your delivery was successful, but you may wish to correct the following issues in your next
delivery: 
> Missing Push Notification Entitlement - Your app appears to include API used to register
with the Apple Push Notification service, but the app signature's entitlements do not include
the "aps-environment" entitlement
> etc...
> The error is because DISABLE_PUSH_NOTIFICATIONS  is disabled by default, so an empty
cordova project has some code referencing push notifications, even if it's not being used.
We should fix that so the developers have a good UX while publishing apps.
> One way we could do this, would be to enable DISABLE_PUSH_NOTIFICATIONS  by default,
and then add a hook to the  cordova plugins that add push notifications, so they'll go and
disable that preprocessor flag.
> Given that the spirit of the platforms/ folders is to be read-only, we should support
in Cordova an easy way of doing this change, and it shouldn't require modifying the iOS project
directly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message