cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9598) Factor out shared logic to cordova-common module and publish it separately.
Date Tue, 06 Oct 2015 09:22:27 GMT

    [ https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944776#comment-14944776
] 

ASF GitHub Bot commented on CB-9598:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/311#discussion_r41242497
  
    --- Diff: cordova-lib/package.json ---
    @@ -40,14 +38,19 @@
         "tar": "1.0.2",
         "underscore": "1.7.0",
         "unorm": "1.3.3",
    -    "valid-identifier": "0.0.1",
    -    "xcode": "0.8.0"
    +    "valid-identifier": "0.0.1"
       },
    +  "bundledDependencies": [
    +    "cordova-common"
    +  ],
       "devDependencies": {
         "istanbul": "^0.3.4",
         "jasmine-node": "1.14.5",
         "jshint": "2.5.8",
    -    "rewire": "2.1.3"
    +    "rewire": "2.1.3",
    +    "osenv": "0.1.0",
    --- End diff --
    
    My bad. Returned plist and xcode back to 'dependencies' section and totally got rid of
osenv module.


> Factor out shared logic to cordova-common module and publish it separately.
> ---------------------------------------------------------------------------
>
>                 Key: CB-9598
>                 URL: https://issues.apache.org/jira/browse/CB-9598
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaCommon, CordovaLib
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> There also a potential problem of code duplication, since the PlatformApi needs for several
classes, which currently being stored and exposed by cordova-lib: ConfigParser, PluginInfo,
etc. The one of solutions of this problem - is to factor out the common classes and routines
to shared module (proposed name - cordova-common), which then will be released separately.
This approach is discussed in cordova-lib/#235



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message