cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9598) Factor out shared logic to cordova-common module and publish it separately.
Date Mon, 05 Oct 2015 11:57:26 GMT

    [ https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943268#comment-14943268
] 

ASF GitHub Bot commented on CB-9598:
------------------------------------

Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/311#issuecomment-145505359
  
    @nikhilkh, please review once more. The failing tests was fixed. 
    ConfigChanges also was reworked in 2e11c52 as per [conversation on dev thread](http://callback.markmail.org/thread/pmtqf6e5yxvmvt7w)


> Factor out shared logic to cordova-common module and publish it separately.
> ---------------------------------------------------------------------------
>
>                 Key: CB-9598
>                 URL: https://issues.apache.org/jira/browse/CB-9598
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaCommon, CordovaLib
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> There also a potential problem of code duplication, since the PlatformApi needs for several
classes, which currently being stored and exposed by cordova-lib: ConfigParser, PluginInfo,
etc. The one of solutions of this problem - is to factor out the common classes and routines
to shared module (proposed name - cordova-common), which then will be released separately.
This approach is discussed in cordova-lib/#235



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message