cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9589) convert old plugin IDs to new plugin IDs using registry-mapper
Date Mon, 05 Oct 2015 08:50:27 GMT

    [ https://issues.apache.org/jira/browse/CB-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943082#comment-14943082
] 

ASF GitHub Bot commented on CB-9589:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/313#discussion_r41121974
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -256,6 +266,15 @@ function runUninstallPlatform(actions, platform, project_dir, plugin_dir,
plugin
             promise = promiseutil.Q_chainmap(danglers, function(dangler) {
                 var dependent_path = path.join(plugins_dir, dangler);
     
    +            //try to convert ID if old-id path doesn't exist. 
    +            if (!fs.existsSync(dependent_path)) {
    +                var splitVersion = dangler.split('@');
    +                var newId = pluginMapper[splitVersion[0]];
    +                if(newId) {
    +                    dependent_path = path.join(plugins_dir, newId);
    --- End diff --
    
    Same here.


> convert old plugin IDs to new plugin IDs using registry-mapper
> --------------------------------------------------------------
>
>                 Key: CB-9589
>                 URL: https://issues.apache.org/jira/browse/CB-9589
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>             Fix For: 5.4.0
>
>
> Right now, cordova-lib will warn developers to use the new plugin id. We want to auto
switch the idea to the new one and fetch from npm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message