cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9589) convert old plugin IDs to new plugin IDs using registry-mapper
Date Mon, 05 Oct 2015 08:50:27 GMT

    [ https://issues.apache.org/jira/browse/CB-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943081#comment-14943081
] 

ASF GitHub Bot commented on CB-9589:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/313#discussion_r41121964
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -142,8 +143,17 @@ module.exports.uninstallPlugin = function(id, plugins_dir, options)
{
             var pluginInfo = pluginInfoProvider.get(depPluginDir);
             // TODO: Should remove dependencies in a separate step, since dependencies depend
on platform.
             var deps = pluginInfo.getDependencies();
    +        var deps_path;
             deps.forEach(function (d) {
    -            if (toDelete.indexOf(d.id) === -1) {
    +            var splitVersion = d.id.split('@');
    +            deps_path = path.join(plugin_dir, '..', splitVersion[0]);
    +            if (!fs.existsSync(deps_path)) {
    +                var newId = pluginMapper[splitVersion[0]];
    +                if (newId && toDelete.indexOf(newId) === -1) {
    +                   toDelete.push(newId);
    --- End diff --
    
    IMHO it makes sense to add verbose message here to show to user what's happened.


> convert old plugin IDs to new plugin IDs using registry-mapper
> --------------------------------------------------------------
>
>                 Key: CB-9589
>                 URL: https://issues.apache.org/jira/browse/CB-9589
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>             Fix For: 5.4.0
>
>
> Right now, cordova-lib will warn developers to use the new plugin id. We want to auto
switch the idea to the new one and fetch from npm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message