cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8875) Splash screen no longer fades when FadeSplashScreen=true
Date Mon, 05 Oct 2015 23:36:27 GMT

    [ https://issues.apache.org/jira/browse/CB-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944255#comment-14944255
] 

ASF GitHub Bot commented on CB-8875:
------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/62

    CB-8875 FadeSplashScreen was not fading

    fixes some weak/strong self identity + confidence issues


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-plugin-splashscreen CB-8875

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----
commit fb0764c528444a665dc611535935d784135ae808
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2015-10-05T23:34:49Z

    CB-8875 FadeSplashScreen was not fading

----


> Splash screen no longer fades when FadeSplashScreen=true
> --------------------------------------------------------
>
>                 Key: CB-8875
>                 URL: https://issues.apache.org/jira/browse/CB-8875
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin SplashScreen
>            Reporter: Chris Karcher
>            Assignee: Jesse MacFadyen
>
> After upgrading to the latest version of the plugin with the fix for [CB-8836], the splash
screen in my iOS app no longer fades even though FadeSplashScreen=true.
> This is the commit that addresses CB-8836:
> [https://github.com/apache/cordova-plugin-splashscreen/commit/559b300d29ba6eb2f951eb19b9bbf7ba9238a862]
> I've found that wrapping the entire call to [UIView transitionWithView] with a dispatch_async
(rather than the individual animation and completion blocks) fixes the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message