cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8826) cordova-plugin-geolocation should reverse permissions request in ios8
Date Wed, 28 Oct 2015 19:41:27 GMT

    [ https://issues.apache.org/jira/browse/CB-8826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979103#comment-14979103
] 

ASF subversion and git services commented on CB-8826:
-----------------------------------------------------

Commit f9dd314b26fe3dfe2bcec2f02e35a5d9519497f8 in cordova-plugin-geolocation's branch refs/heads/master
from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=f9dd314 ]

Merge branch 'CB-8826' of https://github.com/msokk/cordova-plugin-geolocation


> cordova-plugin-geolocation should reverse permissions request in ios8
> ---------------------------------------------------------------------
>
>                 Key: CB-8826
>                 URL: https://issues.apache.org/jira/browse/CB-8826
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Geolocation
>    Affects Versions: 3.4.0
>         Environment: iOS
>            Reporter: Jason Peterson
>            Priority: Minor
>              Labels: easyfix, ios
>             Fix For: Master
>
>
> I would like to suggest a change to how the geolocation plugin requests
> permissions in iOS8.  In the event that both iOS8 NSLocation usage
> permissions exist, I suggest that we first request the least permissive one
> (NSLocationWhenInUseUsageDescription).
> This should amount to simply reversing the logic in CDVLocation.m:
> {code}
> if([[NSBundle mainBundle]
> objectForInfoDictionaryKey:@"NSLocationWhenInUseUsageDescription"])
> {
>             [self.locationManager  requestWhenInUseAuthorization];
> } else if([[NSBundle mainBundle] objectForInfoDictionaryKey:@
> "NSLocationAlwaysUsageDescription"]) {
>             [self.locationManager requestAlwaysAuthorization];
> }
> {code}
> I have a use case where an app launches with both descriptions set, but
> depending on client configuration the "AlwaysInUse" permission may not be necessary.
 As the logic is written now, the plugin will always request that one, which could look a
bit extreme to the end user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message