cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6190) navigator.camera.getPicture ignores quality parameter when width/height are not specified
Date Wed, 14 Oct 2015 14:12:07 GMT

    [ https://issues.apache.org/jira/browse/CB-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956995#comment-14956995
] 

ASF subversion and git services commented on CB-6190:
-----------------------------------------------------

Commit b8a68af63ffb86712941a74884ebd0e32c9a8178 in cordova-plugin-camera's branch refs/heads/master
from [~jcesarmobile]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=b8a68af ]

CB-6190 - iOS camera plugin ignores quality parameter

CB-6190 - iOS camera plugin ignores quality parameter in some
circunstances
Added a check to not downscale if quality is 100 or sourceType !=
UIImagePickerControllerSourceTypeCamera (according to the docs, images
from gallery aren’t downscaled). This closes #108


> navigator.camera.getPicture ignores quality parameter when width/height are not specified
> -----------------------------------------------------------------------------------------
>
>                 Key: CB-6190
>                 URL: https://issues.apache.org/jira/browse/CB-6190
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>         Environment: iOS
>            Reporter: Youval Bronicki
>            Assignee: jcesarmobile
>
> When calling  navigator.camera.getPicture with default options except for quality, the
requested quality is ignored.
> There is a simple work-around, replacing lines 314-315 in CDVCamera.m,  :
> {quote}
> // use image unedited as requested , don't resize
> data = UIImageJPEGRepresentation(returnedImage, 1.0);
> {quote}
> with:
> {quote}
> // use image unedited as requested , don't resize (with compression)
> data = UIImageJPEGRepresentation(returnedImage, cameraPicker.quality / 100.0f);
> {quote}
> However, the code hints there may be some (undocumented?) intention to minimize processing
in some situations, so this may not be a full fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message