cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-9631) 'plugin add --save' saves plugin entry even if plugin installation fails
Date Wed, 09 Sep 2015 14:10:46 GMT

     [ https://issues.apache.org/jira/browse/CB-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vladimir Kotikov updated CB-9631:
---------------------------------
    Description: 
*Repro steps:*
1. cordova create new-app && cd new-app
2. cordova platform add browser
3. cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git --save

Installation fails since no plugin variables specified 

*Expected:*
Because the plugin installation failed, plugin entry is not persisted in config.xml

*Actual:*
config.xml contains plugin entry (empty, without variables).

  was:
*Repro steps:*
1. cordova create new-app && cd new-app
2. cordova platform add browser
3. cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git --save

Installation fails since no plugin variables specified 

*Expected:*
Because the plugin installation failed, plugin entry is not persisted in config.xml

*Actual:*
config.xml contains plugin entry (empty, without variables).

The issue has an aside consequence if the plugin has mandatory variables. After faulty plugin
installation 'cordova prepare' always tries to install plugin again and fails, so strictly
speaking the project is broken until the plugin is not reinstalled correctly.


> 'plugin add --save' saves plugin entry even if plugin installation fails
> ------------------------------------------------------------------------
>
>                 Key: CB-9631
>                 URL: https://issues.apache.org/jira/browse/CB-9631
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> *Repro steps:*
> 1. cordova create new-app && cd new-app
> 2. cordova platform add browser
> 3. cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git --save
> Installation fails since no plugin variables specified 
> *Expected:*
> Because the plugin installation failed, plugin entry is not persisted in config.xml
> *Actual:*
> config.xml contains plugin entry (empty, without variables).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message