cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9604) Error adding browser platform with new PlatformApi polyfill
Date Thu, 03 Sep 2015 06:56:46 GMT

    [ https://issues.apache.org/jira/browse/CB-9604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728584#comment-14728584
] 

ASF GitHub Bot commented on CB-9604:
------------------------------------

Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546
  
    Looks good. However there is another chance to access `this._config` before it will be
initialized: https://github.com/MSOpenTech/cordova-lib/blob/CB-9604/cordova-lib/src/platforms/PlatformApiPoly.js#L162.
    
    Probably it makes sense to eliminate "private" `this._config` and always use `platformInfo.projectConfig`
instead, which need to be a dynamic property with getter? Your thoughts? I can refactor this
by myself after.


> Error adding browser platform with new PlatformApi polyfill
> -----------------------------------------------------------
>
>                 Key: CB-9604
>                 URL: https://issues.apache.org/jira/browse/CB-9604
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>            Priority: Blocker
>
> With the new PlatformApi polyfill in place, I'm seeing the following error when adding
the browser platform:
> {noformat}
> $ cordova platform add browser
> Adding browser project...
> Running command: cmd "/s /c "C:\Users\timba\.cordova\lib\npm_cache\cordova-browser\4.0.0\package\bin\create.bat
D:\CordovaApps\blank\platforms\browser io.cordova.hellocordova HelloCordova""
> Creating Browser project. Path: platforms\browser
> Parsing D:\CordovaApps\blank\platforms\browser\config.xml failed
> Error: ENOENT, no such file or directory 'D:\CordovaApps\blank\platforms\browser\config.xml'
>     at Error (native)
>     at Object.fs.openSync (fs.js:500:18)
>     at Object.fs.readFileSync (fs.js:352:15)
>     at Object.module.exports.parseElementtreeSync (D:\git\cordova-lib\cordova-lib\src\util\xml-helpers.js:118:27)
>     at Object.ConfigParser (D:\git\cordova-lib\cordova-lib\src\configparser\ConfigParser.js:33:24)
>     at new PlatformApiPoly (D:\git\cordova-lib\cordova-lib\src\platforms\PlatformApiPoly.js:68:20)
>     at Object.getPlatformApi (D:\git\cordova-lib\cordova-lib\src\platforms\platforms.js:58:23)
>     at D:\git\cordova-lib\cordova-lib\src\platforms\PlatformApiPoly.js:102:14
>     at _fulfilled (D:\git\cordova-lib\cordova-lib\node_modules\q\q.js:787:54)
>     at self.promiseDispatch.done (D:\git\cordova-lib\cordova-lib\node_modules\q\q.js:816:30)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message