cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9601) Fix <framework>.versions support on Windows after semver update
Date Tue, 08 Sep 2015 16:54:46 GMT

    [ https://issues.apache.org/jira/browse/CB-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735143#comment-14735143
] 

ASF GitHub Bot commented on CB-9601:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/300#issuecomment-138632174
  
    Problem w/ tests is that we have e2e tests but they miss windows10 proj target. Since
I've added more functionality and corresponding tests (+ missing windows10 proj target) in
another PR - #301 I've decided not to duplicate that code here as it will conflict. So if
we merge #301 corresponding tests will be there.
    
    PS. It is hard to split tests on those PRs separately as they both require same changes
like missing windows10 target.


> Fix <framework>.versions support on Windows after semver update
> ---------------------------------------------------------------
>
>                 Key: CB-9601
>                 URL: https://issues.apache.org/jira/browse/CB-9601
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Plugman, Windows
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-lib, plugman, windows
>
> After semver dependency update in LIB@5.2.0 (https://github.com/apache/cordova-lib/commit/bed6d3a201e0193b2ffdb60fa6de74de0c870cec)

> the following version attribute is handled incorrectly and dependency is not installed
to  Windows10 project (CordovaApp.Windows10.jsproj)
> {code}
> <framework src="windows81/bin/TestWinmd.winmd" versions="&gt;=8.1" />
> {code}
> This works correct if I install Cordova 5.1.1 or manually change semver version back
to 2.1.0
> Repro step:
> 1. Add windows platform to cordova app
> 2. Add plugin containt the following element
> {code}
> <framework src="windows81/bin/TestWinmd.winmd" versions="&gt;=8.1" />
> {code}
> 3. Expected: TestWinmd.winmd is added to CordovaApp.Windows10.jsproj (and also to CordovaApp.Phone.jsproj,
CordovaApp.Windows.jsproj)
> 4. Actual:  TestWinmd.winmd is added only to CordovaApp.Phone.jsproj, CordovaApp.Windows.jsproj



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message