cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9490) LG G4 camera application saves photos when using destinationType DATA_URL
Date Mon, 14 Sep 2015 09:31:45 GMT

    [ https://issues.apache.org/jira/browse/CB-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743236#comment-14743236
] 

ASF GitHub Bot commented on CB-9490:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-140016250
  
    @cojomojo the fix makes perfect sense, but I see that the code you use is very similar
to what we have in `checkForDuplicateImage` and looks like that function is not required anymore
(as I think you cover that case) so I propose to rename `checkForDuplicateImage` to `removeTemporaryImages`
(or `cleanupTempImages`) and move your logic there.


> LG G4 camera application saves photos when using destinationType DATA_URL
> -------------------------------------------------------------------------
>
>                 Key: CB-9490
>                 URL: https://issues.apache.org/jira/browse/CB-9490
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>         Environment: LG G4, Android 5.1
>            Reporter: Cody Balos
>            Assignee: Cody Balos
>          Time Spent: 6h
>  Remaining Estimate: 0h
>
> So far this issue only happens on an LG G4 using the stock camera application:
> Using the camera plugin, with destinationType set to DATA_URL,
> the expected functionality is for the base64 string to be returned to the javascript
interface, and not saved to the file system without explicitly saving it separately. Using
the LG G4 stock camera application, all photos are saved even when using destinationType DATA_URL
if the retake option is used. 
> The issue does not occur when using the Google Camera application or Camera 360 (both
on the Play Store). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message