Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 28 Aug 2015 20:43:45 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12859399.1440614115000.198094.1440794625896@Atlassian.JIRA>
In-Reply-To: <JIRA.12859399.1440614115000@Atlassian.JIRA>
References: <JIRA.12859399.1440614115000@Atlassian.JIRA>
 <JIRA.12859399.1440614115177@arcas>
Subject: [jira] [Commented] (CB-9560) Issue using plugin restore for plugins
 with common dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CB-9560?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1472052=
8#comment-14720528 ]=20

ASF GitHub Bot commented on CB-9560:
------------------------------------

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/288#issuecomment-135883534
 =20
    This issue arises because [common.copyFileNew] (https://github.com/apac=
he/cordova-lib/blob/dff78b0779444d06e259140694e07d5e8c5f5308/cordova-lib/sr=
c/plugman/platforms/common.js#L64) throws an exception when it tries to cop=
y a file that already exists, having been placed there by a previously inst=
alled plugin.
    So, I'm curious why does this not show up when we do the copy in serial=
, but shows up when we do it in parallel ?
    Seems fishy to me.


> Issue using plugin restore for plugins with common dependencies
> ---------------------------------------------------------------
>
>                 Key: CB-9560
>                 URL: https://issues.apache.org/jira/browse/CB-9560
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Marcus Pridham
>
> Running into an annoying kind of race condition similar to CB-9278 but fo=
r plugins.  The issue comes up when you have multiple plugins being restore=
d that have common dependencies. =20
> The way restore currently works it is adding all the plugins in config.xm=
l at once. It does NOT wait for the first plugin and its dependencies to be=
 installed before adding the next plugin in the config.xml.  This can cause=
 a plugin to be installed multiple times.  You will get a message like the =
following in the console:
> Failed to install =E2=80=98cordova-plugin-inappbrowser':Error: Uh oh!
> "/Users/i827005/dev/source/odata-demo/platforms/ios/ODataDemo/Plugins/cor=
dova-plugin-inappbrowser/CDVInAppBrowser.m" already exists!


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org