cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9505) Some plugins on windows platform do not loaded correctly using browserify
Date Tue, 18 Aug 2015 11:34:45 GMT

    [ https://issues.apache.org/jira/browse/CB-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701106#comment-14701106
] 

ASF GitHub Bot commented on CB-9505:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/279

    CB-9505 Correct plugin modules loading within browserify flow

    This PR solves problem with a lot of plugins, which uses `js-module` tags with `merges
target=""`. Such modules are not loaded correctly, so, for example, plugin proxies on windows
platform are not available at runtime.
    
    Instead of injecting `modulemapper` methods and `require` calls into bundle, this PR assumes
that bundled plugins modules will be loaded by special 'browserify' version of `cordova/pluginloader`
(see https://github.com/MSOpenTech/cordova-js/blob/CB-9505/src/common/pluginloader_b.js)
    
    This fixes https://issues.apache.org/jira/browse/CB-9505
    
    This PR needs to be merged along with corresponding PR to cordova-js: https://github.com/apache/cordova-js/pull/126

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-9505

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit e3a54a6c545aaa3e5af6d1158acd8f421bbf9131
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2015-08-18T10:43:05Z

    CB-9505 Correct plugin modules loading within browserify flow

----


> Some plugins on windows platform do not loaded correctly using browserify
> -------------------------------------------------------------------------
>
>                 Key: CB-9505
>                 URL: https://issues.apache.org/jira/browse/CB-9505
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>              Labels: browserify, mobilespec, windows
>
> There is some issues with Windows plugins, which makes multiple tests to fail. The most
of these issues are related to incorrect usage of `clobbers/merges` tags instead of `runs`
in plugin definition. This causes plugins' proxies to not to register, so native functionality
is not available to app. Some of plugins affected by this issue:
> # contacts
> # device
> # device-motion
> # device-orientation
> # file-transfer
> # media
> # network-information



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message