cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9482) Uninstall succeeds but reports failure when acted on the Win8.1 Phone Emulator
Date Wed, 12 Aug 2015 23:11:45 GMT

    [ https://issues.apache.org/jira/browse/CB-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694388#comment-14694388
] 

ASF GitHub Bot commented on CB-9482:
------------------------------------

Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/113#discussion_r36925808
  
    --- Diff: template/cordova/lib/deployment.js ---
    @@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices = function() {
         });
     };
     
    +// Note: To account for CB-9482, we pass an extra parameter when retrying the call. 
Be forwarned to check for that
    +// if additional parameters are added in the future.
     AppDeployCmdTool.prototype.installAppPackage = function(pathToAppxPackage, targetDevice,
shouldLaunch, shouldUpdate, pin) {
         var command = shouldUpdate ? '/update' : '/install';
         if (shouldLaunch) {
             command += 'launch';
         }
     
    -    return run(this.path, [command, pathToAppxPackage, '/targetdevice:' + targetDevice.__shorthand]);
    +    var that = this;
    +    var result = run(this.path, [command, pathToAppxPackage, '/targetdevice:' + targetDevice.__shorthand]);
    +    if (targetDevice.type === 'emulator' && arguments.length < 6) {
    --- End diff --
    
    It's called out in the comment immediately preceding the function definition.  There are
5 formal arguments specified to the function, so when the function is called normally, arguments.length
= 5.  In that case, we compose an error handler onto result; the composed error handler is
only called if AppDeployCmd fails.  That handler checks the code to see if it's `E_INVALIDARG`,
and if so, re-calls the function, this time passing an additional parameter.


> Uninstall succeeds but reports failure when acted on the Win8.1 Phone Emulator
> ------------------------------------------------------------------------------
>
>                 Key: CB-9482
>                 URL: https://issues.apache.org/jira/browse/CB-9482
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows
>            Reporter: Rob Paveza
>            Assignee: Rob Paveza
>            Priority: Minor
>              Labels: found-by-ci
>
> The underlying AppDeployCmd /uninstall {app-guid} /targetdevice:{emulator ID} succeeds
in uninstalling an app if it is installed, but reports a failure.  This results in not trying
to install the app subsequently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message