cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9436) Refactor browserify to get rid of `require-tr` transform
Date Tue, 04 Aug 2015 01:57:05 GMT

    [ https://issues.apache.org/jira/browse/CB-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652948#comment-14652948
] 

ASF GitHub Bot commented on CB-9436:
------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-js/pull/124#discussion_r36151389
  
    --- Diff: tasks/lib/bundle-browserify.js ---
    @@ -19,53 +19,63 @@
     var fs           = require('fs');
     var path         = require('path');
     var browserify   = require('browserify');
    -var require_tr   = require('./require-tr');
     var root         = path.join(__dirname, '..', '..');
     var pkgJson      = require('../../package.json');
     var collectFiles = require('./collect-files');
     var copyProps    = require('./copy-props');
     
    -module.exports = function bundle(platform, debug, commitId, platformVersion) {
    -    require_tr.platform = platform;
    -    // FIXME: need to find a way to void ignore missing
    -    var b = browserify({debug: debug});
    -    // XXX plugin_list is not present at this stage 
    -    b.ignore(path.join(root, 'src', 'common', 'plugin_list'));
    +module.exports = function bundle(platform, debug, commitId, platformVersion, platformPath)
{
    +    platformPath = fs.existsSync(platformPath) && fs.existsSync(path.join(platformPath,
'cordova-js-src')) ?
    +        path.join(platformPath, 'cordova-js-src') :
    +        path.resolve(root, 'src', 'legacy-exec', platform);
     
    -    b.transform(require_tr.transform, {'platform': platform});
    +    var platformDirname = platform === 'amazon-fireos' ? 'android' : platform;
    --- End diff --
    
    hahaha smart


> Refactor browserify to get rid of `require-tr` transform
> --------------------------------------------------------
>
>                 Key: CB-9436
>                 URL: https://issues.apache.org/jira/browse/CB-9436
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaJS, CordovaLib
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message