cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-9436) Refactor browserify to get rid of `require-tr` transform
Date Tue, 04 Aug 2015 01:45:04 GMT


ASF GitHub Bot commented on CB-9436:

Github user stevengill commented on the pull request:
    Vladimir! This is a much needed refactor and it looks great! Thank you! The previous spaghetti
code was becoming hard to manage and understand. 
    Things I like:
    * Using `cordova_plugins.js` in the browserify build and removing `cordova_requires`
    * Adding the module name field in `cordova_plugins.js` for each module.
    * Using browserify expose to map `cordova/plugin_list` to `cordova_plugins.js`. (Didn't
even know about expose)
    * Great find with aliasify! Much cleaner way to handle the bad legacy requires in plugins
compared to using requiresTr.
    Quick Question without digging to deep:
    * Wondering why you had to add require('codrdova/init') to the bundle?
How was that getting added previously? 
    I think you fixed all of the remaining bugs with your changes. @surajpindoria will continue
to test on all of the devices we have here to see if we can find bugs.
    I am going to dive deeper into your cordova.js changes now.

> Refactor browserify to get rid of `require-tr` transform
> --------------------------------------------------------
>                 Key: CB-9436
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaJS, CordovaLib
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message