Return-Path: 
 <issues-return-46592-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 07DE91836E
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Fri, 24 Jul 2015 19:22:05 +0000 (UTC)
Received: (qmail 94312 invoked by uid 500); 24 Jul 2015 19:22:04 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 94283 invoked by uid 500); 24 Jul 2015 19:22:04 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 94264 invoked by uid 99); 24 Jul 2015 19:22:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jul 2015 19:22:04 +0000
Date: Fri, 24 Jul 2015 19:22:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12837247.1434059099000.284911.1437765724820@Atlassian.JIRA>
In-Reply-To: <JIRA.12837247.1434059099000@Atlassian.JIRA>
References: <JIRA.12837247.1434059099000@Atlassian.JIRA>
 <JIRA.12837247.1434059099946@arcas>
Subject: [jira] [Commented] (CB-9162) Plugin Variables should support a
 default value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-9162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640953#comment-14640953 ] 

ASF GitHub Bot commented on CB-9162:
------------------------------------

Github user ogoguel commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/247#discussion_r35457112
  
    --- Diff: cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml ---
    @@ -0,0 +1,16 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0"
    +    xmlns:android="http://schemas.android.com/apk/res/android"
    +    id="org.test.defaultvariables"
    +    version="3.0.0">
    +
    +    <name>Use Default Variables</name>
    +
    +    <!-- android -->
    +    <platform name="android">
    +            <preference name="ENABLE_LOG" default="yes" />
    +            <preference name="API_KEY" />
    +    </platform>
    --- End diff --
    
    If you want to override the default variable, just specify it during the plugin installation : 
    ex :` cordova plugin add <plugin_id> --variable ENABLE_LOG=no`  
    This will update the `cordova/plugins/android.json`accordingly, as this is where the variables are being stored (and not in the config.xml)


> Plugin Variables should support a default value
> -----------------------------------------------
>
>                 Key: CB-9162
>                 URL: https://issues.apache.org/jira/browse/CB-9162
>             Project: Apache Cordova
>          Issue Type: Improvement
>            Reporter: Olivier Goguel
>
> When declaring a variable, it is possible to make it mandatory (by using the <preference> tag), but there's no way to make it optional by defining a default value.
> For example: <preference value="ENABLE_LOG" default="true" />
> This would allow users to keep on customizing specific features of the plugins while not having to worry about all the variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org