Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D1D6C18370 for ; Wed, 15 Jul 2015 18:15:04 +0000 (UTC) Received: (qmail 78729 invoked by uid 500); 15 Jul 2015 18:15:04 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 78711 invoked by uid 500); 15 Jul 2015 18:15:04 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 78700 invoked by uid 99); 15 Jul 2015 18:15:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 18:15:04 +0000 Date: Wed, 15 Jul 2015 18:15:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8627) 'cordova plugin add git_url' erroneously updates fetch.json even when the 'add operation fails' MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628483#comment-14628483 ] ASF GitHub Bot commented on CB-8627: ------------------------------------ Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-121700137 What's the status on this PR? > 'cordova plugin add git_url' erroneously updates fetch.json even when the 'add operation fails' > ----------------------------------------------------------------------------------------------- > > Key: CB-8627 > URL: https://issues.apache.org/jira/browse/CB-8627 > Project: Apache Cordova > Issue Type: Bug > Components: CLI > Reporter: Omar Mefire > Assignee: Omar Mefire > > - cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git > This results in fetch.json being updated with the plugin info even though the plugin installation failed. It should not be the case. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org