cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9430) lib/check_reqs.js fails if javac returns an extra line
Date Fri, 31 Jul 2015 13:59:05 GMT

    [ https://issues.apache.org/jira/browse/CB-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649239#comment-14649239
] 

ASF GitHub Bot commented on CB-9430:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-android/pull/204#issuecomment-126699873
  
    LGTM


> lib/check_reqs.js fails if javac returns an extra line
> ------------------------------------------------------
>
>                 Key: CB-9430
>                 URL: https://issues.apache.org/jira/browse/CB-9430
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 4.1.0
>         Environment: ubuntu 14.04, cordova 5.1.1, cordova android@4.1.0
>            Reporter: Vadim Shlyakhov
>            Assignee: Vladimir Kotikov
>              Labels: patch
>
> lib/check_reqs.js fails with
> bq. [TypeError: Cannot read property '1' of null]
>  if javac returns an extra line(s) instead of a single line.
> For example: 
> {quote}
> Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
> javac 1.7.0_79
> {quote}
> instead of simply
> bq. javac 1.7.0_79
> The fix is quite simple:
> {quote}
> {noformat}
> --- check_reqs.js-	2015-07-29 14:21:54.000000000 +0300
> +++ check_reqs.js	2015-07-29 16:11:29.000000000 +0300
> @@ -155,7 +155,7 @@
>              // javac writes version info to stderr instead of stdout
>              return tryCommand('javac -version', msg, true);
>          }).then(function (output) {
> -            return /^javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
> +            return /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
>          });
>      });
>  };
> {noformat}
> {quote}
> i. e. remove leading caret at the parsing regular expression, so it is not anchored to
a beginning of a string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message