cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9426) Exception using device motion plugin on browser platform
Date Wed, 29 Jul 2015 00:28:04 GMT

    [ https://issues.apache.org/jira/browse/CB-9426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645271#comment-14645271
] 

ASF GitHub Bot commented on CB-9426:
------------------------------------

GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/33

    CB-9426 Fix exception using device motion plugin on browser platform

    The plugin's `plugin.xml` defines a general `<js-module>` with the name `accelerometer`.
It defines another `<js-module>` for the `browser` platform with the same name. Modules
with the same name are not allowed, so Cordova throws an exception at runtime when trying
to define the browser version of the module.
    
    Fix is to rename the browser version of the module `browser-accelerometer`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-device-motion CB-9426

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device-motion/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit 15ab61a5b15487fc79e657f973fd5a8bcac0cdbf
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-07-29T00:19:43Z

    CB-9426 Fix exception when using device motion plugin on browser platform.
    
    The plugin's plugin.xml defines a general <js-module> with the name 'accelerometer'.
It defines another <js-module> for the browser platform (that merges with the general
module) with the same name. Modules with the same name is not allowed, so Cordova throws an
exception at runtime when trying to define the browser version of the module.
    
    Fix is to rename the browser module 'browser-accelerometer'.

----


> Exception using device motion plugin on browser platform
> --------------------------------------------------------
>
>                 Key: CB-9426
>                 URL: https://issues.apache.org/jira/browse/CB-9426
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Device Motion
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> When you use the device motion plugin on the browser platform, you get the following
exception:
> {{module cordova-plugin-device-motion.accelerometer already defined}}
> This is because the {{accelerometer}} module name is used twice in plugin.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message