cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9298) Plugins are no longer able to get values from config.xml
Date Mon, 06 Jul 2015 23:13:06 GMT

    [ https://issues.apache.org/jira/browse/CB-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615849#comment-14615849
] 

ASF GitHub Bot commented on CB-9298:
------------------------------------

GitHub user infil00p opened a pull request:

    https://github.com/apache/cordova-android/pull/192

    CB-9298: Preferences are now passed to the Cordova Interface

    I'm doing a pull request instead of just slamming this in because this is actually a pretty
important change that will impact people.  I can't figure out another way to do this, and
I think this will be the least intrusive.  Please look it over and let me know.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infil00p/cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
    
----
commit 2d2fc64c5a8d517c2ace068dfdeecca2b2da9935
Author: Joe Bowser <bowserj@apache.org>
Date:   2015-07-06T22:52:06Z

    CB-9298: Preferences are now passed to the Cordova Interface to be accessible to the plugins

----


> Plugins are no longer able to get values from config.xml
> --------------------------------------------------------
>
>                 Key: CB-9298
>                 URL: https://issues.apache.org/jira/browse/CB-9298
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 4.0.0
>            Reporter: Joe Bowser
>            Assignee: Joe Bowser
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> Due to the security fix, we no longer have a way for third-party plugins to read config.xml.
 We need to put the preferences inside the CordovaInterface.  This wasn't an issue until the
CordovaInterface was separated from the CordovaActivity.  Since we can't guarantee that we'll
even be using a Cordova Activity with any of the WebViews, we need to make sure the Interface
has the preferences when it is created.  This is related to CB-9251.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message