cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9162) Plugin Variables should support a default value
Date Sat, 25 Jul 2015 11:58:05 GMT

    [ https://issues.apache.org/jira/browse/CB-9162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641563#comment-14641563
] 

ASF GitHub Bot commented on CB-9162:
------------------------------------

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/247#discussion_r35482469
  
    --- Diff: cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml ---
    @@ -0,0 +1,16 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0"
    +    xmlns:android="http://schemas.android.com/apk/res/android"
    +    id="org.test.defaultvariables"
    +    version="3.0.0">
    +
    +    <name>Use Default Variables</name>
    +
    +    <!-- android -->
    +    <platform name="android">
    +            <preference name="ENABLE_LOG" default="yes" />
    +            <preference name="API_KEY" />
    +    </platform>
    --- End diff --
    
    If you are creating a plugin, and need to use variables because some values will need
to be defined by the app developer, you *use* the variable by including a reference to it
in values in your plugin's `plugin.xml`. The value of the variable (whether the default value
specified in the `preference` element, or a value supplied by the app developer when the plugin
is added to their project) is substituted for references to the variable in values in `plugin.xml`
when those values are used. See [here](https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html#variables)
for some more info.


> Plugin Variables should support a default value
> -----------------------------------------------
>
>                 Key: CB-9162
>                 URL: https://issues.apache.org/jira/browse/CB-9162
>             Project: Apache Cordova
>          Issue Type: Improvement
>            Reporter: Olivier Goguel
>
> When declaring a variable, it is possible to make it mandatory (by using the <preference>
tag), but there's no way to make it optional by defining a default value.
> For example: <preference value="ENABLE_LOG" default="true" />
> This would allow users to keep on customizing specific features of the plugins while
not having to worry about all the variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message