cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8936) Surface platform-specific logs in buildbot
Date Thu, 16 Jul 2015 01:49:04 GMT

    [ https://issues.apache.org/jira/browse/CB-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629058#comment-14629058
] 

ASF GitHub Bot commented on CB-8936:
------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/58#discussion_r34749430
  
    --- Diff: medic/medic-run.js ---
    @@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) {
                 /^\s*\$appActivator .*$/gim,
                 "$&\n" +
                 "    powershell " + path.join(process.cwd(), destScriptPath) + " $$ID\n"
+
    +            "    powershell " + path.join(process.cwd(), logScriptPath) + "\n" +
                 "    $Ole32 = Add-Type -MemberDefinition '[DllImport(\"Ole32.dll\")]public
static extern int CoAllowSetForegroundWindow(IntPtr pUnk, IntPtr lpvReserved);' -Name 'Ole32'
-Namespace 'Win32' -PassThru\n" +
                 "    $Ole32::CoAllowSetForegroundWindow([System.Runtime.InteropServices.Marshal]::GetIUnknownForObject($appActivator),
[System.IntPtr]::Zero)",
                 appUtilsPath
             );
         }
     
    +    // write current time to a file to use it when gathering logs
    +    var now = new Date();
    +    var iso = now.toISOString();
    +    fs.writeFileSync('startTime.txt', iso, util.DEFAULT_ENCODING);
    --- End diff --
    
    This file is not necessary. It serves only to pass arguments from `medic-run` to `medic-log`.
Instead, please pass a start time to medic-log on the command line from `cordova.conf`. You
can do this by setting a `Property` using `SetPropertyFromCommand`, and then passing it to
the logging step.


> Surface platform-specific logs in buildbot
> ------------------------------------------
>
>                 Key: CB-8936
>                 URL: https://issues.apache.org/jira/browse/CB-8936
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Medic
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>
> Platform specific logs (e.g. logcat for android, stderr.log and stdin.log for iOS etc.)
should be gathered and displayed in buildbot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message