cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Horn (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6227) Plugin is not upgraded when a plugin depends on a specific plugin version, build fails
Date Fri, 10 Jul 2015 19:08:05 GMT

    [ https://issues.apache.org/jira/browse/CB-6227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622770#comment-14622770
] 

Julian Horn commented on CB-6227:
---------------------------------

Can you explain why the build failed?  I would think the source code in File@0.2.5 and File@1.0.1
would be pretty similar, even though they would be installed in different directories because
they have different ids.

Also, what do you think plugman should do in this case?

It seems like there are two choices. Plugman can treat the old and new File as different versions
of the same plugin or as two different plugins. If you treat these as two different plugins,
then loading cordova-plugin-media should bring in cordova-plugin-file, and the fact that you
already have org.apache.cordova.file is no barrier.  I would expect that configuration would
also fail to build, but I could be wrong.  In any case both File plugin versions can't really
coexist because they define the same global names.

What's happening here feels like plugman is attempting to treat the old and new File as different
versions of the same plugin.  In that case, plugman is doing the right thing.  If you fetch
a plugin that has a dependency on a plugin you already have (File@0.2.5), then the plugin
is not re-fetched, even if the version you have does not satisfy the version attribute in
the <dependency> tag.  This would happen even if the plugin hadn't been renamed.

> Plugin is not upgraded when a plugin depends on a specific plugin version, build fails
> --------------------------------------------------------------------------------------
>
>                 Key: CB-6227
>                 URL: https://issues.apache.org/jira/browse/CB-6227
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, Plugman
>    Affects Versions: Master
>            Reporter: Shazron Abdullah
>
> Repro steps:
> 1. Install File plugin 0.2.5
> {code}
> cordova plugin add org.apache.cordova.file@0.2.5
> {code}
> 2. Install Media plugin with File@1.0.1 dependency (see CB-6225)
> {code}
> cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-media.git#dev
> {code}
> 3. Build the project, it fails
> {code}
> cordova build
> {code}
> *Expected:*
> The dependent plugin version of File@1.0.1 by Media upgrades the currently installed
version of File@0.2.5
> *Actual:*
> The dependent plugin version of File@1.0.1 by Media does not upgrade the currently installed
version of File@0.2.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message