Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 383F1181E8 for ; Thu, 18 Jun 2015 22:08:01 +0000 (UTC) Received: (qmail 51480 invoked by uid 500); 18 Jun 2015 22:08:01 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 51460 invoked by uid 500); 18 Jun 2015 22:08:01 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 51442 invoked by uid 99); 18 Jun 2015 22:08:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2015 22:08:01 +0000 Date: Thu, 18 Jun 2015 22:08:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592625#comment-14592625 ] ASF subversion and git services commented on CB-9158: ----------------------------------------------------- Commit 74aa099b7e69ddc067a46c06e20d593ef5a0874a in cordova-plugin-inappbrowser's branch refs/heads/master from [~syndbg] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=74aa099 ] CB-9158 - InAppBrowser zoomControls are always set to true > InAppBrowser zoomControls are always set to true > ------------------------------------------------ > > Key: CB-9158 > URL: https://issues.apache.org/jira/browse/CB-9158 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Affects Versions: 3.5.0 > Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device > Reporter: Anton Antonov > Labels: easyfix, patch > > InAppBrowser does not respect the passed options string to *window.open*. > *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. > Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 > P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org