Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FE9B18A9D for ; Wed, 17 Jun 2015 19:31:02 +0000 (UTC) Received: (qmail 59896 invoked by uid 500); 17 Jun 2015 19:31:02 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 59877 invoked by uid 500); 17 Jun 2015 19:31:02 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 59805 invoked by uid 99); 17 Jun 2015 19:31:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jun 2015 19:31:01 +0000 Date: Wed, 17 Jun 2015 19:31:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590407#comment-14590407 ] ASF GitHub Bot commented on CB-9109: ------------------------------------ Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32665147 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout', '*.xcscheme', - ]; +]; + +var RAT_IGNORE_PATH = '.ratignore'; +var RATIGNORE_COMMENT_PREFIX = '#'; + +var RAT_NAME = 'apache-rat-0.10'; +var RAT_URL = 'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz'; + +function startsWith(string, prefix) { + return string.lastIndexOf(prefix, 0) === 0; --- End diff -- using lastIndexOf will fail with this won't it? startsWith("boomboom","boom"); // false? string.indexOf(prefix) === 0 is not only correct, but easier to understand too > Switch to using .ratignore in cordova repositories > -------------------------------------------------- > > Key: CB-9109 > URL: https://issues.apache.org/jira/browse/CB-9109 > Project: Apache Cordova > Issue Type: Improvement > Components: Coho > Reporter: Dmitry Blotsky > Assignee: Dmitry Blotsky > Labels: coho, rat > Original Estimate: 24h > Remaining Estimate: 24h > > Move from using ratExcludes in repoutils.js within COHO to using a .ratignore file in each respective repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org