Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 377711835C for ; Tue, 23 Jun 2015 12:25:01 +0000 (UTC) Received: (qmail 27149 invoked by uid 500); 23 Jun 2015 12:25:01 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 27126 invoked by uid 500); 23 Jun 2015 12:25:01 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 27115 invoked by uid 99); 23 Jun 2015 12:25:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2015 12:25:00 +0000 Date: Tue, 23 Jun 2015 12:25:00 +0000 (UTC) From: "Alexander Sorokin (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8971) 'Duplicate cordova' check breaks Ripple MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597575#comment-14597575 ] Alexander Sorokin commented on CB-8971: --------------------------------------- I think this is fixed now? > 'Duplicate cordova' check breaks Ripple > --------------------------------------- > > Key: CB-8971 > URL: https://issues.apache.org/jira/browse/CB-8971 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS > Affects Versions: 5.0.0 > Reporter: Tim Barham > > Ripple defines a setter for {{window.cordova}} so it can intercapt the {{cordova}} object being created, and patch {{cordova.exec}}. This breaks the new 'duplicate cordova' check, which looks for {{'cordova' in window}}, which will return {{true}} in Ripple. The alternative, {{window.cordova}}, will work, since that remains undefined in Ripple. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org