cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
Date Thu, 18 Jun 2015 22:12:01 GMT


ASF GitHub Bot commented on CB-9158:

Github user purplecabbage commented on the pull request:
    I have tested the change, and verified it. So it is now merged.
    Thanks for the contribution @syndbg 
    Some great next steps would be to document the feature (under android quirks) and to add
a manual test to the list in the /tests/tests.js file.

> InAppBrowser zoomControls are always set to true
> ------------------------------------------------
>                 Key: CB-9158
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 3.5.0
>         Environment: Latest InAppBrowser,
any Android device
>            Reporter: Anton Antonov
>              Labels: easyfix, patch
> InAppBrowser does not respect the passed options string to **.
> *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming
it's boolean true.
> Fix is in
> P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message