cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
Date Thu, 18 Jun 2015 22:08:00 GMT

    [ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592625#comment-14592625
] 

ASF subversion and git services commented on CB-9158:
-----------------------------------------------------

Commit 74aa099b7e69ddc067a46c06e20d593ef5a0874a in cordova-plugin-inappbrowser's branch refs/heads/master
from [~syndbg]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=74aa099 ]

CB-9158 - InAppBrowser zoomControls are always set to true


> InAppBrowser zoomControls are always set to true
> ------------------------------------------------
>
>                 Key: CB-9158
>                 URL: https://issues.apache.org/jira/browse/CB-9158
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 3.5.0
>         Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser,
any Android device
>            Reporter: Anton Antonov
>              Labels: easyfix, patch
>
> InAppBrowser does not respect the passed options string to *window.open*.
> *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming
it's boolean true.
> Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104
> P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message