cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-9158) InAppBrowser zoomControls are always set to true
Date Wed, 17 Jun 2015 22:50:00 GMT

     [ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anton Antonov updated CB-9158:
------------------------------
    Description: 
InAppBrowser does not respect the passed options string to *window.open*.

*zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's
boolean true.

Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104


P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.

  was:
InAppBrowser does not respect the passed options string to *window.open*.

*location=no* or *location=yes* will never make a difference due to source code always assuming
it's boolean true.

Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104


P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.


> InAppBrowser zoomControls are always set to true
> ------------------------------------------------
>
>                 Key: CB-9158
>                 URL: https://issues.apache.org/jira/browse/CB-9158
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 3.5.0
>         Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser,
any Android device
>            Reporter: Anton Antonov
>              Labels: easyfix, patch
>
> InAppBrowser does not respect the passed options string to *window.open*.
> *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming
it's boolean true.
> Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104
> P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message