cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9145) prepare can lose data during config munge
Date Mon, 15 Jun 2015 21:26:00 GMT

    [ https://issues.apache.org/jira/browse/CB-9145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586740#comment-14586740
] 

ASF GitHub Bot commented on CB-9145:
------------------------------------

Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-lib/pull/242#issuecomment-112216370
  
    lgtm :+1: 


> prepare can lose data during config munge
> -----------------------------------------
>
>                 Key: CB-9145
>                 URL: https://issues.apache.org/jira/browse/CB-9145
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tony Homer
>            Assignee: Tony Homer
>
> If a node is added to config.xml with same name and matching attributes as an existing
node, but it is missing attributes, it is treated as an exact match during config munge and
is not added to platform config.xml.  For example, when the following tags are present in
www/config.xml, then second tag will not be added to platforms/android/res/xml/config.xml:
> {code}
> <access origin="*" launch-external="yes"/>
> <access origin="*" />
> {code}
> AFAIK, this is most important for access tags, but will affect any tag where it is possible
for one tag to be a subset of another tag.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message